voyage/lib/review
Kjell Tore Guttormsen b0d96a2d53
fix: close what an independent review found in the trial 2 fixes
- The pre-compact hook read only a checkpoint that started with `git commit`,
  so every plan in the new `git add … && git commit` form rebuilt nothing, and
  an empty match also skipped the session-state refresh. It now finds the
  commit anywhere in the span and always refreshes; first test for the hook.
- A sub-bullet that carries its own command stays a criterion (folding it
  left the command unrun); the shallowest bullet sets the base indent.
- Only a MINOR/SUGGESTION /code-review finding outside the range is released
  from forbidding ALLOW: a MAJOR one may be a break cited at an unchanged
  caller.
- `reuse` is an improvement category; the session-spec template stages too;
  a negated bash 3.2 constraint, an env prefix and `bash -c` are handled.
- Stale comment, Declined-to-Judge wording and rule-key counts brought in line.

Tests fail on 7c11c2a first (9 of 24).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 15:21:56 +02:00
..
coordinator-contract.mjs fix: close what an independent review found in the trial 2 fixes 2026-10-08 15:21:56 +02:00
engine-findings.mjs fix: close what an independent review found in the trial 2 fixes 2026-10-08 15:21:56 +02:00
fidelity-diff.mjs feat(voyage): S10 — NW2 part A (Workflow port + fidelity harness + smoke) 2026-06-18 14:40:19 +02:00
fill-finding-ids.mjs fix(review): the review keeps the findings that are right 2026-10-08 06:48:13 +02:00
findings-schema.mjs fix: close the six defects an independent review found in the trial fixes 2026-10-08 07:17:45 +02:00
gold-scorer.mjs fix(review): write the gold-scorer key separator as an escape, not a raw NUL byte 2026-09-17 15:36:18 +02:00
plan-review-dedup.mjs feat(plan): plan 1.8, the plan gate, the design part and the plan-side checks 2026-10-06 20:10:57 +02:00
recurrence.mjs fix(review): close the gate's fail-open paths an independent review found 2026-10-06 20:03:16 +02:00
rule-catalogue.mjs fix: close what an independent review found in the trial 2 fixes 2026-10-08 15:21:56 +02:00
verdict-gate.mjs fix(review): a review with a control that did not run stops a merge 2026-10-06 20:06:29 +02:00