Kjell Tore Guttormsen
33b58f460a
1. A step of only tests can never be proven red. One reading, stepTestsOnly (lib/parsers/plan-schema.mjs, test paths from the new lib/util/test-path.mjs): the plan validator warns PLAN_STEP_TESTS_ONLY, red-proof --plan/--step adds tests_only to a not-red-at-base, and /trekexecute and the step helper send such a step straight up to the plan instead of into fix rounds that cannot succeed. /trekplan, the plan template and plan-critic (dimension 8, still 12) say the test belongs in the step that builds the behaviour. 2. Timing tests under load: the hook helper's kill limit is 30 s and per call overridable; SC #14 passes on the fastest of up to three runs against the same 800 ms limit (tests/helpers/timing.mjs). 3. The example plan's On failure lines open with a K11 word. 4. /trekreview saves the reviewer's whole answer for the findings check and names FINDING_PROSE_LINE_OUT_OF_RANGE (error: re-ask; warning: report). 5. The criteria runner's commands run without NODE_TEST_CONTEXT (commandEnv, moved to lib/util/command-env.mjs). 6. The resolver returns effort only when the brief's phase signal sets one; the four commands said it always did. Also: the K2 hook tests used fixed session ids in a per-user temp dir, so two suites running at once took each other's approval records; the ids are now unique per run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
15 lines
507 B
JavaScript
15 lines
507 B
JavaScript
// lib/util/test-path.mjs
|
|
// What counts as a test file, by its path. One reading for every caller: the
|
|
// floor guard (test-integrity.mjs) reads a diff with it, and the plan reader
|
|
// (plan-schema.mjs `stepTestsOnly`) asks whether a step holds nothing but tests.
|
|
|
|
const TEST_PATH_RE = [
|
|
/(^|\/)(tests?|__tests__|spec|specs)\//,
|
|
/\.(test|spec)\.[a-z0-9]+$/i,
|
|
/_(test|spec)\.[a-z0-9]+$/i,
|
|
/(^|\/)test_[^/]*\.py$/,
|
|
];
|
|
|
|
export function isTestPath(p) {
|
|
return TEST_PATH_RE.some((re) => re.test(p));
|
|
}
|