voyage/agents
Kjell Tore Guttormsen 5cb2918baa
feat(review): the critic's own security key SECURITY_RISK (decision 167)
lib/review/rule-catalogue.mjs gains SECURITY_RISK (BLOCKER, category
security, memory route rule): Voyage's own security key for a finding by
its own reviewers that SECURITY_INJECTION does not cover.
SECURITY_REVIEW_VULNERABILITY is described as the engines' key only.
plan-critic and scope-guardian name SECURITY_INJECTION or SECURITY_RISK
and no longer the engines' key.

The count moves from 17 to 18 in every pin: rule-catalogue.test,
claude-md-scope [CAT] (which now also refuses a stale 17), doc-consistency,
review-prose-pins, docs/architecture.md and the two reviewer agents.
critic-severity-rules pins three security keys; its "every security key
named" check leaves out the engines' key, and a new pin says the critic
never names it.

Existing tests changed for the planned rule: the four count pins above
(17 -> 18), and critic-severity-rules' two-key test (now three keys).
tests/lib/engine-findings.test.mjs: a comment naming the "(17 keys)" pin
now says 18.

Part 2, step 2.3 of the E plan.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 08:55:34 +01:00
..
architecture-mapper.md fix(agents): no agent is pinned below the high floor 2026-10-05 17:40:53 +02:00
brief-conformance-reviewer.md feat(review): the critic's own security key SECURITY_RISK (decision 167) 2026-11-08 08:55:34 +01:00
brief-reviewer.md fix(docs): name /trekplan where the text sent readers to a reference document, and give the reference documents read-only tools 2026-10-22 14:23:05 +02:00
code-correctness-reviewer.md feat(review): the critic's own security key SECURITY_RISK (decision 167) 2026-11-08 08:55:34 +01:00
community-researcher.md feat(research): researching-sources skill, preloaded by the five web agents 2026-10-08 21:46:49 +02:00
contrarian-researcher.md feat(research): researching-sources skill, preloaded by the five web agents 2026-10-08 21:46:49 +02:00
convention-scanner.md refactor(agents): relocate example blocks to body (retrieval agents) 2026-06-29 10:16:48 +02:00
dependency-tracer.md fix(agents): no agent is pinned below the high floor 2026-10-05 17:40:53 +02:00
docs-researcher.md feat(research): researching-sources skill, preloaded by the five web agents 2026-10-08 21:46:49 +02:00
git-historian.md feat(trekplan): Regression and On failure step rules, and trial 2's minor fixes 2026-10-08 21:42:21 +02:00
plan-critic.md feat(review): the critic's own security key SECURITY_RISK (decision 167) 2026-11-08 08:55:34 +01:00
research-scout.md fix(agents): reviewers drop a finding only with a Declined to Judge line, research-scout gets Tavily, no dead override reference 2026-10-22 14:11:47 +02:00
review-coordinator.md chore(cleanup): R-b R3 — profiles, phase signals and the effort dialog removed, one fixed path per command 2026-11-07 21:12:57 +01:00
risk-assessor.md refactor(agents): relocate example blocks to body (reviewer/planning agents) 2026-06-29 10:19:24 +02:00
scope-guardian.md feat(review): the critic's own security key SECURITY_RISK (decision 167) 2026-11-08 08:55:34 +01:00
security-researcher.md feat(research): researching-sources skill, preloaded by the five web agents 2026-10-08 21:46:49 +02:00
session-decomposer.md fix(docs): name /trekplan where the text sent readers to a reference document, and give the reference documents read-only tools 2026-10-22 14:23:05 +02:00
step-implementer.md fix(execute): below 1.8 a plan that names no test file gets the files the helper wrote 2026-10-14 18:17:24 +02:00
task-finder.md fix(agents): no agent is pinned below the high floor 2026-10-05 17:40:53 +02:00
test-strategist.md refactor(agents): relocate example blocks to body (retrieval agents) 2026-06-29 10:16:48 +02:00