voyage/commands
Kjell Tore Guttormsen 609eb35015
fix(review): the review keeps the findings that are right
voyage-lekerepo end-to-end trial (2026-10-06), report points 1, 5, 11:

- engine-findings: recommended_action is "Fix <file:line> so this no longer
  happens: <failure scenario>", not "Resolve: <title>" (8 of 8 engine
  findings were set aside as actionability:empty); the coordinator never
  sets an engine finding aside for Actionability.
- findings-schema --repo-root: a cited line past the end of an existing
  file is FINDING_LINE_OUT_OF_RANGE, so Phase 5's bounded re-ask fixes it
  before the coordinator sees it. The reviewers' instruction said "the
  actual line number from the diff"; it now says the file's own line,
  never the patch's.
- fill-finding-ids.mjs: the coordinator (no shell) writes @@ID_<n>@@ and
  trekreview Phase 7 computes them over (file, line, rule_key); an
  unresolved placeholder or a wrong 40-hex id fails. The 4-field id with
  `title` the docs named is gone; the code always used three.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 06:48:13 +02:00
..
trekbrief.md fix(validate): a check that can never run is caught when the brief or plan is written 2026-10-08 06:42:33 +02:00
trekcontinue.md feat(commands): drop orchestrator model pins - inherit session model 2026-07-02 17:09:49 +02:00
trekendsession.md fix(trekendsession): release v5.9.1 - eager-exec blocks crashed command load 2026-07-03 01:11:02 +02:00
trekexecute.md fix(validate): a check that can never run is caught when the brief or plan is written 2026-10-08 06:42:33 +02:00
trekplan.md fix(validate): a check that can never run is caught when the brief or plan is written 2026-10-08 06:42:33 +02:00
trekresearch.md fix(commands): the VOYAGE_ROOT fallback writes $(0), not $0 2026-10-02 16:02:13 +02:00
trekreview.md fix(review): the review keeps the findings that are right 2026-10-08 06:48:13 +02:00