Round 7 (516dffa..45aa9e1, WARN: 12 MAJOR, 0 BLOCKER) and the fence defect
found while writing its review.md. Each fix began with a test that failed on
0f400d3 (v6.3.0); suite 2208 (2206/0/2), 14 tests more.
- Tests-only (operator 2026-10-11): the plan's Files: alone decides, and the
text says so (red-proof, trekexecute Sub-step B, step-implementer,
HANDOVER-CONTRACTS). red-proof no longer reads the step's diff, so a change
already in the tree when the step began no longer counts against it, and a
plan placed outside .claude/ reads the same. The round-6 test that had the
diff overrule the plan is rewritten to the new rule.
- The Files: reader keeps a plain file beside a backticked path
(", Dockerfile", "the CLI entry src/cli.mjs", "and Makefile"). Measured on
the 520 Files: fields in 182 plans: no field reads differently.
- Red proof reports a command its timeout killed as killed after the timeout,
not "could not start"; the release check tells a timeout from output past
its buffer and from another signal. One reading of a stop
(criteria-runner stoppedBy) for red proof, the criteria runner and the
release check.
- A trailing `# comment` is dropped in a backticked check too, and in a
command passed as written, so the words screened are the words run.
- The release check reads a relative --review in --repo.
- The 15-minute timeout is defined once (criteria-runner.mjs).
- The findings check reads each cited file once per validation.
- One isMain helper (lib/util/is-main.mjs) for every CLI: the 31 copies of
the realpath guard and the 20 modules still on the file:// guard, which
exited 0 having done nothing under a symlink or a path with a space.
- The Bash guard writes its no-one-to-ask refusal once, on a direct condition.
- The findings check ends a ```json block only at a fence on its own line, so
three backticks inside a JSON string no longer end it (also in 6.2.0).
- Brief-conformance notes: a test for test-lock green on exit 127 (it
passed at once; it fails when 127 is read as could-not-run); the prose now
names the git revision `@~1` as the one leading-@ exception.
Not changed: the example plan's steps 1-2 keep their tests-only warning
(operator decision 2026-10-09; the r5 test records it). Brief note 4 (a
Regression: whose runner is not installed goes to the fix rounds) is a
routing question for the operator.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
83 lines
3.6 KiB
JavaScript
83 lines
3.6 KiB
JavaScript
// lib/stats/stats-append.mjs
|
|
// Append one command-stats record to <data dir>/<kind>-stats.jsonl.
|
|
//
|
|
// Why this exists: the commands' stats phases said "append to
|
|
// ${CLAUDE_PLUGIN_DATA}/<kind>-stats.jsonl; if it is not set, skip silently".
|
|
// The Bash tool's env carries no CLAUDE_PLUGIN_DATA, so the record was skipped
|
|
// whenever the model did not guess the directory itself — the same silent skip
|
|
// that left brief-approved at 0 records. This writer resolves the directory
|
|
// the way scripts/yardstick.mjs reads it, and a failed write is REPORTED
|
|
// (exit 1 + reason), never swallowed. Stats still never block the workflow:
|
|
// the command prose reports the failure and carries on.
|
|
//
|
|
// A `trekbrief` record also carries the coord-queue order the run is working
|
|
// on: order_id, order_claimed_at, order_reason, found by
|
|
// lib/stats/claimed-order.mjs in the queue itself. The WRITER adds them - any
|
|
// order_* key the record arrived with is dropped first - so the model never
|
|
// types an order id, and the keys are always present (null + reason when no
|
|
// single order can be named; absent keys mean the record predates this).
|
|
//
|
|
// CLI (the record is read from stdin, so no shell quoting of JSON):
|
|
// node lib/stats/stats-append.mjs <kind> <<'JSON'
|
|
// { ...record... }
|
|
// JSON
|
|
// → prints {"written":true,"path":...} exit 0 | {"written":false,"reason":...} exit 1
|
|
|
|
import { appendFileSync, mkdirSync, readFileSync } from 'node:fs';
|
|
import { homedir } from 'node:os';
|
|
import { join } from 'node:path';
|
|
import { attributeOrder } from './claimed-order.mjs';
|
|
import { isMain } from '../util/is-main.mjs';
|
|
|
|
export const STATS_KINDS = Object.freeze([
|
|
'trekbrief', 'trekresearch', 'trekplan', 'trekexecute', 'trekreview', 'trekcontinue',
|
|
]);
|
|
|
|
/**
|
|
* The plugin data directory: CLAUDE_PLUGIN_DATA when the harness provides it,
|
|
* otherwise the directory the hooks write to and scripts/yardstick.mjs reads.
|
|
*/
|
|
export function resolveStatsDir(env = process.env) {
|
|
if (env.CLAUDE_PLUGIN_DATA) return env.CLAUDE_PLUGIN_DATA;
|
|
const home = env.HOME && env.HOME.length > 0 ? env.HOME : homedir();
|
|
return join(home, '.claude', 'plugins', 'data', 'voyage-ktg-plugin-marketplace');
|
|
}
|
|
|
|
/**
|
|
* @returns {{ written: boolean, path: string|null, reason?: string }}
|
|
*/
|
|
export function appendStatsRecord(kind, record, env = process.env, { cwd = process.cwd() } = {}) {
|
|
if (!STATS_KINDS.includes(kind)) {
|
|
return { written: false, path: null, reason: `unknown kind "${kind}" (one of ${STATS_KINDS.join(', ')})` };
|
|
}
|
|
if (!record || typeof record !== 'object' || Array.isArray(record)) {
|
|
return { written: false, path: null, reason: 'record must be a JSON object' };
|
|
}
|
|
if (kind === 'trekbrief') {
|
|
const own = Object.fromEntries(Object.entries(record).filter(([k]) => !k.startsWith('order_')));
|
|
record = { ...own, ...attributeOrder({ cwd, env, projectDir: record.project_dir }) };
|
|
}
|
|
const dir = resolveStatsDir(env);
|
|
const path = join(dir, `${kind}-stats.jsonl`);
|
|
try {
|
|
mkdirSync(dir, { recursive: true });
|
|
appendFileSync(path, JSON.stringify(record) + '\n');
|
|
} catch (e) {
|
|
return { written: false, path, reason: `${e.code || 'write-failed'}: ${e.message}` };
|
|
}
|
|
return { written: true, path };
|
|
}
|
|
|
|
if (isMain(import.meta.url)) {
|
|
const kind = process.argv[2];
|
|
let record = null;
|
|
let reason = null;
|
|
try {
|
|
record = JSON.parse(readFileSync(0, 'utf8'));
|
|
} catch (e) {
|
|
reason = `stdin is not JSON: ${e.message}`;
|
|
}
|
|
const r = reason ? { written: false, path: null, reason } : appendStatsRecord(kind, record);
|
|
process.stdout.write(JSON.stringify(r) + '\n');
|
|
process.exit(r.written ? 0 : 1);
|
|
}
|