voyage/lib/review
Kjell Tore Guttormsen 5f9faeed4a
fix: close the six defects an independent review found in the trial fixes
Independent read-only review of c56f852..2d29966 (2026-10-08), each defect
reproduced by the reviewer; each new test fails on that code.

- test-lock green ran ANY allowlisted command: `green --cmd "git status"`
  marked a red step green and the stop guard let it stop. The lock now
  stores the step's test command (`lock --cmd`); `green` runs only that
  one (a different --cmd, or a lock without one, exits 2). trekexecute D1
  calls `green` with no command, which also removes the quoting hazard.
- plan-gate --accept-open worked at round 1 and passed the gate; it now
  refuses while rounds are left.
- findings-schema --repo-root swallowed a following flag, or took a root
  that does not exist, and silently skipped the line check: exit 2.
- brief-review-stamp hashed only the body, so a changed `framing` or
  `research_topics` stayed "current"; it now covers the reviewed
  frontmatter too (only the post-review stamps are left out).
- red-proof red_kind read an assertion message naming SyntaxError as a
  load error; the signatures are now specific.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 07:17:45 +02:00
..
coordinator-contract.mjs fix(review): the review keeps the findings that are right 2026-10-08 06:48:13 +02:00
engine-findings.mjs fix(review): the review keeps the findings that are right 2026-10-08 06:48:13 +02:00
fidelity-diff.mjs feat(voyage): S10 — NW2 part A (Workflow port + fidelity harness + smoke) 2026-06-18 14:40:19 +02:00
fill-finding-ids.mjs fix(review): the review keeps the findings that are right 2026-10-08 06:48:13 +02:00
findings-schema.mjs fix: close the six defects an independent review found in the trial fixes 2026-10-08 07:17:45 +02:00
gold-scorer.mjs fix(review): write the gold-scorer key separator as an escape, not a raw NUL byte 2026-09-17 15:36:18 +02:00
plan-review-dedup.mjs feat(plan): plan 1.8, the plan gate, the design part and the plan-side checks 2026-10-06 20:10:57 +02:00
recurrence.mjs fix(review): close the gate's fail-open paths an independent review found 2026-10-06 20:03:16 +02:00
rule-catalogue.mjs fix(review): close the gate's fail-open paths an independent review found 2026-10-06 20:03:16 +02:00
verdict-gate.mjs fix(review): a review with a control that did not run stops a merge 2026-10-06 20:06:29 +02:00