Kjell Tore Guttormsen
d88245c06e
Ordre 5 (wave 1, P11 + P5), review_version 1.1. - K7: `verdict: ALLOW | WARN | BLOCK` is required in review.md (strict error, soft warning for 1.0 reviews). New CLI lib/review/verdict-gate.mjs: 0 = ALLOW/WARN, 1 = BLOCK, 2 = could not decide (never green); a verdict greener than the file's own BLOCKERs or JSON block is exit 2. Realpath main guard (the old file:// guard exits 0 under a symlink - measured). - No finding is struck for length: succinctness trims only MINOR/SUGGESTION text (catalogue tier), keeps BLOCKER/MAJOR whole, counts trims; the coordinator lists what it declined to judge. - Claude Code's /code-review and /security-review run as the engine via the Skill tool (never --fix/--comment/--post/ultra); lib/review/engine-findings.mjs turns their findings into a reviewer payload; two catalogue keys (CODE_REVIEW_DEFECT, SECURITY_REVIEW_VULNERABILITY), catalogue 12 -> 14. An engine that did not run forbids ALLOW. - Every BLOCKER is written as a numbered `### Step R<n>` with its source finding (strict error REVIEW_MISSING_REMEDIATION_STEP). - P5: lib/review/recurrence.mjs - a finding class in two review.md files (current + git history, no new store) becomes one proposal, routed by the catalogue's memory_route; written only between Voyage markers in .claude/rules/voyage-review-lessons.md under a size budget, CLAUDE.md gets a pointer only; the operator approves every line (Phase 8.7). - Workflow substrate: catalogue enum in step; a missing reviewer or engine forbids ALLOW there too (it returned ALLOW on zero findings before). - Fixtures review-run-A/B said WARN over a BLOCKER; now BLOCK. Borrowed and credited in code: Superpowers (declined-to-judge), ai-native-sdlc (cap only nits; mistake/fix/check), Spec Kit (managed block; converge steps), Pocock (retro routing), Kiro (verdict file + gate; evidence per lesson), Cherny (engine -> brief control order; review -> memory; budget). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
70 lines
3 KiB
JavaScript
70 lines
3 KiB
JavaScript
import { test } from 'node:test';
|
|
import { strict as assert } from 'node:assert';
|
|
import {
|
|
RULE_CATALOGUE,
|
|
RULE_KEYS,
|
|
SEVERITY_VALUES,
|
|
CATEGORY_VALUES,
|
|
getRule,
|
|
MEMORY_ROUTES,
|
|
} from '../../lib/review/rule-catalogue.mjs';
|
|
|
|
test('RULE_CATALOGUE — every entry has all 4 required fields', () => {
|
|
for (const entry of RULE_CATALOGUE) {
|
|
assert.ok(typeof entry.rule_key === 'string' && entry.rule_key.length > 0, `bad rule_key: ${entry.rule_key}`);
|
|
assert.ok(typeof entry.severity === 'string' && entry.severity.length > 0, `bad severity: ${entry.severity}`);
|
|
assert.ok(typeof entry.category === 'string' && entry.category.length > 0, `bad category: ${entry.category}`);
|
|
assert.ok(typeof entry.description === 'string' && entry.description.length > 0, `bad description for ${entry.rule_key}`);
|
|
}
|
|
});
|
|
|
|
test('RULE_CATALOGUE — no duplicate rule_key', () => {
|
|
const seen = new Set();
|
|
for (const entry of RULE_CATALOGUE) {
|
|
assert.ok(!seen.has(entry.rule_key), `duplicate rule_key: ${entry.rule_key}`);
|
|
seen.add(entry.rule_key);
|
|
}
|
|
assert.equal(seen.size, RULE_CATALOGUE.length);
|
|
});
|
|
|
|
test('RULE_CATALOGUE — all severity values within enum', () => {
|
|
for (const entry of RULE_CATALOGUE) {
|
|
assert.ok(SEVERITY_VALUES.includes(entry.severity), `${entry.rule_key} has invalid severity: ${entry.severity}`);
|
|
}
|
|
});
|
|
|
|
test('RULE_CATALOGUE — all category values within enum', () => {
|
|
for (const entry of RULE_CATALOGUE) {
|
|
assert.ok(CATEGORY_VALUES.includes(entry.category), `${entry.rule_key} has invalid category: ${entry.category}`);
|
|
}
|
|
});
|
|
|
|
test('RULE_KEYS.size === RULE_CATALOGUE.length (== 14) — pinned by doc-consistency', () => {
|
|
assert.equal(RULE_KEYS.size, RULE_CATALOGUE.length);
|
|
assert.equal(RULE_CATALOGUE.length, 14);
|
|
});
|
|
|
|
test('RULE_CATALOGUE — the two Claude Code engine keys exist at their tiers (ordre 5)', () => {
|
|
assert.equal(getRule('CODE_REVIEW_DEFECT')?.severity, 'MAJOR');
|
|
assert.equal(getRule('SECURITY_REVIEW_VULNERABILITY')?.severity, 'BLOCKER');
|
|
});
|
|
|
|
test('RULE_CATALOGUE — every entry declares a memory_route (check | rule | null)', () => {
|
|
for (const entry of RULE_CATALOGUE) {
|
|
assert.ok('memory_route' in entry, `${entry.rule_key} has no memory_route`);
|
|
assert.ok(entry.memory_route === null || MEMORY_ROUTES.includes(entry.memory_route),
|
|
`${entry.rule_key} has invalid memory_route: ${entry.memory_route}`);
|
|
}
|
|
assert.equal(getRule('MISSING_BRIEF_REF').memory_route, null, 'review hygiene is never project memory');
|
|
assert.equal(getRule('COVERAGE_SILENT_SKIP').memory_route, null, 'review hygiene is never project memory');
|
|
});
|
|
|
|
test('getRule — returns frozen entry on hit, null on miss, null on bad input', () => {
|
|
const hit = getRule('UNIMPLEMENTED_CRITERION');
|
|
assert.ok(hit !== null);
|
|
assert.equal(hit.severity, 'BLOCKER');
|
|
assert.throws(() => { hit.severity = 'MINOR'; }); // frozen
|
|
assert.equal(getRule('NOPE'), null);
|
|
assert.equal(getRule(undefined), null);
|
|
assert.equal(getRule(123), null);
|
|
});
|