Kjell Tore Guttormsen
66b3b15fb6
S2 of the 2.1.181 upgrade. Schemas verified verbatim against the official
slash-commands and hooks docs before editing (a first-pass camelCase
'disallowedTools' claim was caught and corrected to kebab-case against the doc).
- CC-14 (SHIP): migrate all 7 hooks in hooks/hooks.json to exec-form
{command:"node", args:["${CLAUDE_PLUGIN_ROOT}/hooks/scripts/X.mjs"]}. Doc
recommends exec-form whenever a hook references a path placeholder; protects
consumers installing under a path with spaces. ${CLAUDE_PLUGIN_ROOT}
interpolates inside args (verified). hooks-json-stop-wired test made
form-agnostic (normalizes command+args to one invocation string).
- CC-11 (SHIP): add `disallowed-tools: Agent, TeamCreate` to trekexecute
frontmatter, enforcing its documented "No Agent tool, no TeamCreate" rule.
allowed-tools grants auto-approval but does NOT remove tools from the pool,
so the prior omission left Agent callable; disallowed-tools removes it.
trekexecute is the only command with a documented exclusion.
- CC-15 (DECIDE: keep universal): re-affirm F2 deferral. pre-bash/pre-write
executors stay universal -- session-agnostic safety (rm -rf /, ~/.ssh, .env)
that narrowing to execute-only would only weaken. Header comments corrected.
- CC-10 (DECIDE: design note, no code): no blanket Agent(model:opus) deny rule
-- would break balanced/economy profiles; any model-enforcement must be
profile-aware, deferred into W2. Folded into open question #3.
Matrix updated with S2 resolutions section. Tests 578 pass / 0 fail / 2 skip;
claude plugin validate passes (only pre-existing root-CLAUDE.md warning).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LqBYc8Ltrk7LipyJmGxXiB
73 lines
2.8 KiB
JavaScript
73 lines
2.8 KiB
JavaScript
// SC-13: hooks.json wires Stop event to otel-export.mjs
|
|
// HIGH-risk-mitigering — verify deterministic config-pinning (mønster fra
|
|
// tests/lib/doc-consistency.test.mjs).
|
|
|
|
import { test } from 'node:test';
|
|
import { strict as assert } from 'node:assert';
|
|
import { readFileSync } from 'node:fs';
|
|
import { fileURLToPath } from 'node:url';
|
|
import { dirname, resolve } from 'node:path';
|
|
|
|
const __dirname = dirname(fileURLToPath(import.meta.url));
|
|
const HOOKS_JSON_PATH = resolve(__dirname, '../../hooks/hooks.json');
|
|
|
|
function loadHooksJson() {
|
|
const raw = readFileSync(HOOKS_JSON_PATH, 'utf8');
|
|
return JSON.parse(raw);
|
|
}
|
|
|
|
// Hooks may use shell form ({command: "node X.mjs"}) or exec form
|
|
// ({command: "node", args: ["X.mjs"]}, CC 2.1.139). Normalize both to a single
|
|
// invocation string so assertions are form-agnostic.
|
|
function invocationOf(h) {
|
|
return [h.command || '', ...(h.args || [])].join(' ').trim();
|
|
}
|
|
|
|
test('hooks.json — Stop key exists with at least one entry', () => {
|
|
const cfg = loadHooksJson();
|
|
assert.ok(cfg.hooks, 'hooks.json mangler top-level "hooks" object');
|
|
assert.ok(Array.isArray(cfg.hooks.Stop), 'hooks.json mangler "Stop" array');
|
|
assert.ok(cfg.hooks.Stop.length >= 1, 'Stop array er tom — forventet ≥1 entry');
|
|
});
|
|
|
|
test('hooks.json — Stop entry refererer otel-export.mjs', () => {
|
|
const cfg = loadHooksJson();
|
|
const stopEntries = cfg.hooks.Stop;
|
|
const allInvocations = stopEntries.flatMap((entry) =>
|
|
(entry.hooks || []).map(invocationOf),
|
|
);
|
|
const hasOtelExport = allInvocations.some((cmd) => cmd.includes('otel-export.mjs'));
|
|
assert.ok(
|
|
hasOtelExport,
|
|
`ingen Stop-hook refererer otel-export.mjs. Funnet: ${JSON.stringify(allInvocations)}`,
|
|
);
|
|
});
|
|
|
|
test('hooks.json — Stop entry bruker ${CLAUDE_PLUGIN_ROOT}-substitusjon', () => {
|
|
const cfg = loadHooksJson();
|
|
const stopEntries = cfg.hooks.Stop;
|
|
const otelEntry = stopEntries
|
|
.flatMap((entry) => entry.hooks || [])
|
|
.find((h) => invocationOf(h).includes('otel-export.mjs'));
|
|
assert.ok(otelEntry, 'fant ikke otel-export-entry i Stop');
|
|
const otelInvocation = invocationOf(otelEntry);
|
|
assert.match(
|
|
otelInvocation,
|
|
/\$\{CLAUDE_PLUGIN_ROOT\}/,
|
|
'otel-export-invocation bruker ikke ${CLAUDE_PLUGIN_ROOT}-prefix — relative paths feiler i headless',
|
|
);
|
|
assert.match(
|
|
otelInvocation,
|
|
/^node\s+/,
|
|
'otel-export-invocation starter ikke med "node " — invocation-form ikke korrekt',
|
|
);
|
|
});
|
|
|
|
test('hooks.json — Stop entry har "type": "command"', () => {
|
|
const cfg = loadHooksJson();
|
|
const stopEntries = cfg.hooks.Stop;
|
|
const otelHook = stopEntries
|
|
.flatMap((entry) => entry.hooks || [])
|
|
.find((h) => invocationOf(h).includes('otel-export.mjs'));
|
|
assert.equal(otelHook.type, 'command', 'otel-export-hook mangler "type": "command"');
|
|
});
|