voyage/lib/review
Kjell Tore Guttormsen c47061191c
feat(review): the brief's threat model on the review side (decision 164, 167, 218)
The code-correctness reviewer's dimension 6 shrinks to what the engines do
not read: command, skill and agent markdown carrying shell, with Claude
Code's threshold (a concrete attack path, high confidence), the keys
SECURITY_INJECTION or SECURITY_RISK, and threat_model_ref quoting the
brief's Outside: line; the code-level bullets go to the engines.

The coordinator puts a Voyage security finding with a threat_model_ref
into the trailing JSON block's known_outside, never into findings.
review-finalize gains the pass `outside`, right after engine: it only
raises. An entry the brief at the review's brief_path does not back now
(line gone, threat model not usable, an engine finding, not a security
finding) goes back into the findings at its catalogue tier with a Source
line, R-step and raised verdict, as the engine put-back does; the rest are
listed under the new `## Outside the Threat Model` section.

verdict-gate decideOpenFindings (and so scripts/release-check.mjs)
re-checks every entry against brief_path through the new
notBackedOutside and exits 2 for one not backed. review-validator
shape-checks the optional known_outside (REVIEW_KNOWN_OUTSIDE_MALFORMED).
threat-model.mjs gains reviewThreatModel and isKnownEntry for the three.

/trekreview Phase 8.8 lists the known issues outside the threat model
(not answered, not counted); the review template shows the section and
field; Handover 1 names the optional ## Threat Model and its code,
Handover 6 names known_outside and its code.

Part 2, step 2.5 of the E plan.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 09:14:47 +01:00
..
coordinator-contract.mjs chore(cleanup): R-b R3 — profiles, phase signals and the effort dialog removed, one fixed path per command 2026-11-07 21:12:57 +01:00
critic-diff.mjs fix(review): plan dedup ranks a merged pair by what rule B counts, so reviewer order never lowers a blocker 2026-10-16 16:46:10 +02:00
engine-compare.mjs refactor(cleanup): simplify pass on the R-a diff 2026-11-07 13:31:30 +01:00
engine-findings.mjs fix: close the gaps the review of the trial-5 fixes found 2026-10-18 20:11:08 +02:00
fill-finding-ids.mjs fix(review): one reviewer's two findings on one triplet keep a row each 2026-10-18 19:50:20 +02:00
findings-schema.mjs chore(cleanup): remove the June trials, orchestrator docs, dormant agent, caller-less code and the fix-round chain 2026-11-07 12:51:54 +01:00
instruction-scope.mjs refactor: simplify pass (trekexecute) 2026-11-04 11:29:46 +01:00
merge-evidence.mjs refactor: simplify pass (trekexecute) 2026-11-04 11:29:46 +01:00
plan-review-dedup.mjs feat(gate): the brief's threat model on the plan side (decision 164, 218, 220) 2026-11-08 09:04:08 +01:00
pre-existing.mjs feat(review): stop rule in the review rounds (decision 217, 220) 2026-11-08 07:13:07 +01:00
recurrence.mjs refactor: simplify pass (trekexecute) 2026-10-28 16:34:32 +01:00
review-answers.mjs feat(review): stop rule in the review rounds (decision 217, 220) 2026-11-08 07:13:07 +01:00
review-finalize.mjs feat(review): the brief's threat model on the review side (decision 164, 167, 218) 2026-11-08 09:14:47 +01:00
review-policy.mjs feat(review): a REVIEW.md policy caps and skips MINOR findings only 2026-11-02 19:43:54 +01:00
review-rounds.mjs fix(gate): part 1 verifier findings — stop-rule wording, guard tests, unreadable round 2026-11-08 07:39:00 +01:00
reviewed-commit.mjs fix(review): R6 checks every parent of a commit after the review 2026-11-03 11:07:08 +01:00
rule-catalogue.mjs feat(review): the critic's own security key SECURITY_RISK (decision 167) 2026-11-08 08:55:34 +01:00
stop-rule.mjs feat(review): one shared stop rule for the plan loop and review rounds (decision 217) 2026-11-08 06:58:45 +01:00
threat-model.mjs feat(review): the brief's threat model on the review side (decision 164, 167, 218) 2026-11-08 09:14:47 +01:00
verdict-gate.mjs feat(review): the brief's threat model on the review side (decision 164, 167, 218) 2026-11-08 09:14:47 +01:00