voyage/tests/helpers
Kjell Tore Guttormsen f820081bdc
refactor(review): simplify pass over E (reuse, simplification, efficiency)
Quality only, no behaviour change (four cleanup reviewers, one implementer;
npm test 2480/0 on the working tree):

- threat-model.mjs splitBacked(): the one known_outside backing check of
  plan-gate (record and bare gate), verdict-gate and review-finalize, with
  one why-text; the engines' security keys derived from ENGINES; isSecurity.
- coordinator-contract: "not a security engine" read from ENGINES (a string
  engine only), not the code-review literal.
- review-rounds owns trailingBlock, findingsBlockSha, isMajor, isBlocker;
  review-answers imports them (review-rounds still imports nothing from it).
  prepare keeps the archive bytes it read instead of reading the previous
  archive again.
- engine-compare exports rowIn and payloadEngine; finalize uses them.
- plan-gate: one accepted_open builder; the stop-rule check hoisted; one
  top-level lookup for --record --brief.
- security-engine: notFullShas(), runCli's usage flag, readScopeList shared
  with engine-findings; findReport and reviewRoundSummary module-private;
  two dead defaults gone.
- tests: shared plan-gate harness and threat-model brief helpers; the [CNV]
  table cases call convertReport in-process, one CLI case per exit path.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 21:27:59 +01:00
..
artifact-repo.mjs refactor(simplify): one source per rule, shared test helpers, a faster isolation test [skip-docs] 2026-10-12 21:06:47 +02:00
bin-path.mjs fix: round 9 of the release review of 6.3.0, for 6.3.1 2026-10-11 12:49:01 +02:00
changelog-section.mjs test(changelog): find the 6.4.0 section by its title, before and after the release commit 2026-10-17 00:13:32 +02:00
child-env.mjs fix(tests): the suite no longer hands the session id to the lock CLI 2026-10-12 14:09:14 +02:00
claude-security-report.mjs fix(review): convert refuses a partial or scoped Claude Security report; the stamp check is a trace (decisions 223, 224) 2026-11-08 18:24:39 +01:00
hook-helper.mjs fix(tests): the post-compact hook test takes its child timeout from the shared timing helper 2026-10-15 15:43:36 +02:00
md-section.mjs refactor(cleanup): simplify pass on the R-a diff 2026-11-07 13:31:30 +01:00
no-session-id.mjs fix(tests): the suite no longer hands the session id to the lock CLI 2026-10-12 14:09:14 +02:00
plan-gate-harness.mjs refactor(review): simplify pass over E (reuse, simplification, efficiency) 2026-11-08 21:27:59 +01:00
plan-v18-builder.mjs feat(plan): read Files by the 1.9 grammar, warn on unticked paths below it [skip-docs] 2026-10-12 16:09:25 +02:00
red-judge.mjs test(r8): move the live tests out of the round files 2026-11-07 10:19:49 +01:00
red-mutate.mjs feat(red-proof): one red script that takes base, ids, mutations and files as arguments 2026-10-26 12:38:44 +01:00
red-reporter.mjs test(r8): move the live tests out of the round files 2026-11-07 10:19:49 +01:00
red-round.sh feat(red-proof): one red script that takes base, ids, mutations and files as arguments 2026-10-26 12:38:44 +01:00
threat-model-brief.mjs refactor(review): simplify pass over E (reuse, simplification, efficiency) 2026-11-08 21:27:59 +01:00
timing.mjs fix(tests): the post-compact hook test takes its child timeout from the shared timing helper 2026-10-15 15:43:36 +02:00