Kjell Tore Guttormsen
2a35d067d9
The four profiles, the resolver, the profile validator and docs/profiles.md go; /trekbrief Phase 3.5 and the brief's phase_signals checks go (an older brief's key is ignored); MANIFEST_PROFILE_DRIFT and profile_used go. Every Profile, Composition rule, Sequencing gate and High-effort section leaves the commands. Decision 209: /trekresearch runs the full swarm with contrarian-researcher as wave 2 every run; /trekreview and the coordinator run all four passes with no high-effort normalization. Voyage agents are spawned with no model (their own model: opus applies); the two built-in spawns pass model "opus". --profile stays in the parser as a retired flag that swallows its value. §Model & effort moves to docs/architecture.md; the sequencing-gate eval case goes. Files removed: 44 (43 from the R3 list + tests/commands/trekreview.test.mjs, whose every test pinned removed text). Files edited: 43. Tests: 2467 (2466 pass / 0 fail / 1 skipped) before, 2309 (2309 pass / 0 fail / 0 skipped) after. Durable check: all three groups green, none pending. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
74 lines
1.7 KiB
Bash
Executable file
74 lines
1.7 KiB
Bash
Executable file
#!/bin/bash
|
|
# Seeds the empty run workspace with a project folder whose review.md carries a finding ID that is not 40-char hex.
|
|
# Self-contained on purpose: the run cannot read the eval directory, and the
|
|
# fixtures are written inline so no path outside the workspace is involved.
|
|
set -eu
|
|
mkdir -p proj
|
|
cat > proj/brief.md <<'BRIEF'
|
|
---
|
|
type: trekbrief
|
|
brief_version: "2.1"
|
|
created: 2026-09-23
|
|
task: "Eval fixture: add a greeting helper"
|
|
slug: eval-greeting
|
|
project_dir: proj/
|
|
research_topics: 0
|
|
research_status: skipped
|
|
auto_research: false
|
|
interview_turns: 1
|
|
source: fixture
|
|
---
|
|
|
|
# Task: add a greeting helper
|
|
|
|
## Intent
|
|
|
|
Eval fixture for the Voyage proevesett. Not a real task.
|
|
|
|
## Goal
|
|
|
|
A function `greet(name)` returns `Hello, <name>!`.
|
|
|
|
## Success Criteria
|
|
|
|
- `greet("Ada")` returns `Hello, Ada!`.
|
|
BRIEF
|
|
cat > proj/review.md <<'REVIEW'
|
|
---
|
|
type: trekreview
|
|
review_version: "1.0"
|
|
created: 2026-09-23
|
|
task: "Eval fixture: add a greeting helper"
|
|
slug: eval-greeting
|
|
project_dir: proj/
|
|
brief_path: proj/brief.md
|
|
scope_sha_start: 0123456789abcdef0123456789abcdef01234567
|
|
scope_sha_end: fedcba9876543210fedcba9876543210fedcba98
|
|
reviewed_files_count: 1
|
|
verdict: ALLOW
|
|
findings:
|
|
- F-001
|
|
---
|
|
|
|
# Review: add a greeting helper
|
|
|
|
## Executive Summary
|
|
|
|
Eval fixture. One SUGGESTION, verdict ALLOW.
|
|
|
|
## Coverage
|
|
|
|
One file reviewed: `src/greet.js`.
|
|
|
|
## Findings (SUGGESTION)
|
|
|
|
- `src/greet.js:1` - name the parameter more descriptively.
|
|
|
|
## Remediation Summary
|
|
|
|
Nothing blocks. The suggestion is optional.
|
|
|
|
```json
|
|
{"findings":[{"id":"d2d0e27875ae9ef0d818cb08bb6f14e6d33c4232","severity":"SUGGESTION","file":"src/greet.js","line":1,"rule_key":"naming","title":"Parameter name","detail":"Eval fixture.","recommended_action":"Rename the parameter."}]}
|
|
```
|
|
REVIEW
|