voyage/commands
Kjell Tore Guttormsen f6e8529bdd
fix(review): convert refuses a partial or scoped Claude Security report; the stamp check is a trace (decisions 223, 224)
Two fail-closed checks in security-engine.mjs convert (decision 224), both
"not measured" (exit 2, the reason on stderr, nothing on stdout):
- the stamp's findings.total is not a non-negative integer, or the JSONL
  holds another number of records (a JSONL that lost the only BLOCKER line
  converted clean before; part 3 verifier, F3);
- the stamp's scope is not an empty list: a scan limited by --scope, an
  absent scope or a non-list scope (Claude Security 0.12.0 writes scope: []
  for an unscoped scan; F4).
The real Claude Security 0.12.0 probe report still converts: exit 0, one
BLOCKER, two below_threshold.

Decision 223, text only: the module header and SECURITY.md keep the
head/base check and say it is a trace, not a signature: code the reviewed
run executed can write a report folder of its own (convert reads the
matching one whose name sorts last) or delete the real one first (F2, a
known issue). /trekreview's not-measured list names the two new reasons.

The test helper writes the real stamp shape by default (findings.total =
the records in the JSONL written, scope: []). New tests for behaviour that
had none (F6): no fallback from an unverified newest match, a two-stamp
folder passed over, a symlinked stamp, JSONL or folder refused, a malformed
or absent scan_prefix, an unrecorded empty_diff or empty_scope.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 18:24:39 +01:00
..
trekbrief.md feat(brief): optional threat model in the brief (decision 164, 218) 2026-11-08 08:47:51 +01:00
trekcontinue.md chore(cleanup): R-b R3 — profiles, phase signals and the effort dialog removed, one fixed path per command 2026-11-07 21:12:57 +01:00
trekendsession.md fix(trekendsession): Phase 3 re-reads the arguments instead of splicing the label into the shell line 2026-10-26 16:12:44 +01:00
trekexecute.md docs(review): /trekreview chooses its security engine (E 3.2) 2026-11-08 13:39:44 +01:00
trekplan.md docs(gate): decision 221 stated where the plan loop reads it 2026-11-08 12:23:25 +01:00
trekresearch.md fix(cleanup): R-b review round — retired flags in the prose parsers 2026-11-07 21:36:13 +01:00
trekreview.md fix(review): convert refuses a partial or scoped Claude Security report; the stamp check is a trace (decisions 223, 224) 2026-11-08 18:24:39 +01:00