voyage/lib/review
Kjell Tore Guttormsen f6e8529bdd
fix(review): convert refuses a partial or scoped Claude Security report; the stamp check is a trace (decisions 223, 224)
Two fail-closed checks in security-engine.mjs convert (decision 224), both
"not measured" (exit 2, the reason on stderr, nothing on stdout):
- the stamp's findings.total is not a non-negative integer, or the JSONL
  holds another number of records (a JSONL that lost the only BLOCKER line
  converted clean before; part 3 verifier, F3);
- the stamp's scope is not an empty list: a scan limited by --scope, an
  absent scope or a non-list scope (Claude Security 0.12.0 writes scope: []
  for an unscoped scan; F4).
The real Claude Security 0.12.0 probe report still converts: exit 0, one
BLOCKER, two below_threshold.

Decision 223, text only: the module header and SECURITY.md keep the
head/base check and say it is a trace, not a signature: code the reviewed
run executed can write a report folder of its own (convert reads the
matching one whose name sorts last) or delete the real one first (F2, a
known issue). /trekreview's not-measured list names the two new reasons.

The test helper writes the real stamp shape by default (findings.total =
the records in the JSONL written, scope: []). New tests for behaviour that
had none (F6): no fallback from an unverified newest match, a two-stamp
folder passed over, a symlinked stamp, JSONL or folder refused, a malformed
or absent scan_prefix, an unrecorded empty_diff or empty_scope.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 18:24:39 +01:00
..
coordinator-contract.mjs feat(review): the security engine chosen and Claude Security converted (E 3.1) 2026-11-08 13:29:59 +01:00
critic-diff.mjs fix(review): plan dedup ranks a merged pair by what rule B counts, so reviewer order never lowers a blocker 2026-10-16 16:46:10 +02:00
engine-compare.mjs feat(review): the security engine chosen and Claude Security converted (E 3.1) 2026-11-08 13:29:59 +01:00
engine-findings.mjs feat(review): the security engine chosen and Claude Security converted (E 3.1) 2026-11-08 13:29:59 +01:00
fill-finding-ids.mjs fix(review): one reviewer's two findings on one triplet keep a row each 2026-10-18 19:50:20 +02:00
findings-schema.mjs chore(cleanup): remove the June trials, orchestrator docs, dormant agent, caller-less code and the fix-round chain 2026-11-07 12:51:54 +01:00
instruction-scope.mjs refactor: simplify pass (trekexecute) 2026-11-04 11:29:46 +01:00
merge-evidence.mjs refactor: simplify pass (trekexecute) 2026-11-04 11:29:46 +01:00
plan-review-dedup.mjs fix(gate): part 2 verifier findings — non-object findings, carried backed copy, rule_keys, marks, approval prose, brief_path, engine put-back once 2026-11-08 10:50:20 +01:00
pre-existing.mjs feat(review): stop rule in the review rounds (decision 217, 220) 2026-11-08 07:13:07 +01:00
recurrence.mjs refactor: simplify pass (trekexecute) 2026-10-28 16:34:32 +01:00
review-answers.mjs feat(review): the security engine chosen and Claude Security converted (E 3.1) 2026-11-08 13:29:59 +01:00
review-finalize.mjs fix(review): an engine finding raised again outside findings stays counted (decision 222) 2026-11-08 18:22:49 +01:00
review-policy.mjs feat(review): a REVIEW.md policy caps and skips MINOR findings only 2026-11-02 19:43:54 +01:00
review-rounds.mjs fix(review): an engine finding raised again outside findings stays counted (decision 222) 2026-11-08 18:22:49 +01:00
reviewed-commit.mjs fix(review): R6 checks every parent of a commit after the review 2026-11-03 11:07:08 +01:00
rule-catalogue.mjs feat(review): the security engine chosen and Claude Security converted (E 3.1) 2026-11-08 13:29:59 +01:00
security-engine.mjs fix(review): convert refuses a partial or scoped Claude Security report; the stamp check is a trace (decisions 223, 224) 2026-11-08 18:24:39 +01:00
stop-rule.mjs feat(review): one shared stop rule for the plan loop and review rounds (decision 217) 2026-11-08 06:58:45 +01:00
threat-model.mjs fix(gate): part 2 verifier findings — non-object findings, carried backed copy, rule_keys, marks, approval prose, brief_path, engine put-back once 2026-11-08 10:50:20 +01:00
verdict-gate.mjs feat(review): the brief's threat model on the review side (decision 164, 167, 218) 2026-11-08 09:14:47 +01:00