Commit graph

3 commits

Author SHA1 Message Date
a5a13b010a docs(migration): record that step 5 never reached the published repos
org-ops reported that 30-fix-references.mjs:3-5 promises a disclosure-link
rewrite that 10 published plugin repos do not have. Confirmed by measurement,
at each plugin's catalog-pinned tag rather than in the sibling working trees:
10 of 12 still carry ../../README.md#ai-generated-code-disclosure on README.md:7.
Only repo-mailbox and repo-standard — both created after the migration — are clean.

The rewriter is not broken. Its DISCLOSURE_LINK regex was re-verified against the
live text at okr@v1.8.2:README.md:7 and matches, so "fix the script" would have
been a no-op. What never happened is the application: the migration's push half
was operator-gated and ran 0 pushes (review.md:79), so this step's output never
reached the content that was published. The header was true about the code and
false about the outcome — which is exactly how it got read as a receipt.

The header now says so, with the measurement date and method. Remediation is not
the catalog's to make: each plugin repo owns its README, and all 10 were notified.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015bmkz7r2zycwwG2kcCCf9H
2026-08-03 21:12:50 +02:00
85a8ee345e fix(migration): re-review MAJOR (30-fix-references) — drop stale repository.directory + test the package.json branch
The /trekreview re-review's high-effort deep read of 30-fix-references.mjs
surfaced 2 MAJOR (both pre-existing in the original delivery, not remediation
regressions):

- PLAN_EXECUTE_DRIFT: the rewriter set repository.url but left a monorepo-relative
  repository.directory (e.g. llm-security's plugins/llm-security) intact, so the
  standalone package.json/plugin.json shipped a directory pointing nowhere. Now
  dropped in BOTH the plugin.json (3a) and package.json (3b) object branches;
  idempotency preserved (gated on 'directory' in repository).
- MISSING_TEST: the package.json rewrite branch only ran against voyage/llm-security
  but the only test used graceful-handoff (no package.json) — unguarded. Added a test
  driving both branches against a synthetic llm-security extract (pre-init .git,
  fixtures carrying repository.directory), asserting reconciliation + directory-drop
  on both files + idempotency.

Independent code-correctness reviewer re-verified both RESOLVED, no new issue.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-17 19:22:21 +02:00
45322d297a chore(migration): standalone reference-rot rewriter 2026-06-17 12:46:18 +02:00