Every fixture, test document, tool example and document now uses an invented kitchen-and-baking handbook series, written in this repository. The package's behaviour is unchanged; src/ changes are comments and help text only. - Generated fixtures are regenerated from their generators. Their structural counts are identical before and after: elements, images, rows, cells, headings, bookmarks and the witness inventory's per-document totals. The image-inbox and accounting documents are renamed kapittel-84-*. - tools/okf_accounting_gate.py: the two options that named one real corpus each are replaced by a generic, repeatable --corpus PATH with no default. Row 5 compares the PDF pair alone. Gate verdict unchanged: RED rows 2, 3, 6. - tools/okf_witness.py: the STS JSON reader for one publisher's delivery is removed, along with its three twins and five tests. The mutation harness loses W09. - docs/: 13 dated reports that documented runs on a retired reference corpus are removed, and 40 are neutralized. Dead links are removed, and no new dangling path is introduced. - The synthetic MCP-gate corpus and the residual probe words are neutral. Valgt: keep the `okf quality --fasit` bar value (the measured fraction, one corpus) and rewrite only its provenance, because the verdict stays unchanged and the number names nothing. Term check with the local list: 0 of 411 tracked files, 0 file names, 0 of 27 binary fixtures. Suite after git add: 2457 passed, 1 skipped. The base tree had 2460 passed and 2 skipped; five tests went with the JSON reader and four were added by the term check. ruff, ruff format and mypy --strict src/ are clean. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
10 KiB
The chain, not its first link — and a backstop nothing held
CORRECTION, 2026-09-18 (round 3). This report's three-class split is wrong on one class. It states that
ASCII85DecodeandASCIIHexDecodeare "bounded by their own input because they shrink".zis ASCII85's shorthand for four zero bytes, so that filter QUADRUPLES its input, andbase64.a85decodecosts about a hundred bytes of memory per byte of input. Measured on the pinned tree of0c3c490, the commit this report closes: a 33 475-byte PDF decoding an image through[/FlateDecode /ASCII85Decode]cost 3 261 599 744 bytes of peak RSS and the picture was CARRIED with no rejection. Everything else here stands — the chain walk, the backstop, the paired corpus numbers — and what replaced the class is a measured cost ratio per filter, recorded indocs/2026-09-18-utgangsbudsjett-per-ledd.md. The text below is left as it was written.
A PM checkpoint of 0f308c1 — the commit that was to make v0.10.1 true —
read the fix for the deflate bomb and found the bound still reachable, through
a shape the fix had not considered: a PDF decodes a stream through a list
of filters, and the fix measured filters[0].
This report records what was measured, what changed, and what the new rule
costs on real documents. The two rounds it follows are
docs/2026-09-17-bildestien-0-10-1.md and
docs/2026-09-18-bildestien-holder-0-10-1.md.
BLOCKER — the bound measured one link of a chain
_check_inflated did this:
filters = stream.get_filters()
if not filters or filters[0][0] not in LITERALS_FLATE_DECODE:
return
inflated_size(raw, name=name)
Two holes, and the second was invisible because the first looked like the whole rule.
- A chain of two
FlateDecodelinks passes the check. The first link of/Filter [/FlateDecode /FlateDecode]inflates 795 bytes to 407 685 — well under the bound — and the check returns.get_data()then applies both links and produces 400 MB. - A chain whose first link is not
FlateDecodeis not measured at all.[/ASCII85Decode /FlateDecode]returns on the first line.
Measured on 0f308c1 in its own interpreter (peak RSS is RUSAGE_SELF of a
subprocess, not the high-water mark of the test session):
| chain | file | peak RSS | carried |
|---|---|---|---|
[/FlateDecode], 400 MB |
408 516 B | 59 232 256 B | 0, asset_too_large |
[/FlateDecode /FlateDecode], 400 MB |
1 636 B | 886 554 624 B | 0, asset_too_large |
[/FlateDecode /FlateDecode /FlateDecode], 400 MB |
1 070 B | 889 393 152 B | 0, asset_too_large |
[/FlateDecode /FlateDecode], 1,2 GB |
2 927 B | 2 567 204 864 B | 0, asset_too_large |
About 543 000x the file size at two links. Note the last column: the picture
is refused — by check_payload after get_data(), which is the counted
refusal, not the bounded one. A test reading only the rejection code is green
on this defect, which is why two of the tests written here assert which
check fired, by its message.
The pre-fix figures were measured from a git archive of 3b587ea on
PYTHONPATH, not from the editable tree, and the census below prints the
imported module's __file__ as its own control.
The chain is not a hypothetical
Every image XObject of the 78 PDFs on this machine, by filter chain
(2026-09-18, 5 142 objects, get_filters() as pdfminer resolves it):
| chain | objects |
|---|---|
[/DCTDecode] |
1 654 |
[/FlateDecode] |
2 236 |
[/FlateDecode /DCTDecode] |
596 |
[/FlateDecode /ASCII85Decode] |
580 |
| (no filter) | 40 |
[/ASCII85Decode /FlateDecode] |
16 |
[/JPXDecode] |
16 |
[/CCITTFaxDecode] |
4 |
1 192 real pictures are reached through a chain, so refusing every chain was
not available. 16 of them sit behind an ASCII85Decode and were unmeasured.
What the rule is now
_check_stream_cost walks every link, in order, and the filters fall in
three classes (extract.bounded_pdf_filters, pinned by a test):
FlateDecodeis measured — inflated a chunk at a time, output discarded, refused the moment the running total crosses the bound. A link with another expanding link behind it is inflated under the same bound and handed on, so what is held is never more than the bound.ASCII85DecodeandASCIIHexDecodeshrink by construction (five characters to four bytes, two to one), so their output is bounded by their input, which is already in memory as part of the file. They are decoded here so aFlateDecodebehind one can be measured.DCTDecode,JPXDecodeandJBIG2Decodeare pass-through in pdfminer: it hands the compressed image on for the reader to sniff, and the size does not change.
Everything else — LZWDecode, RunLengthDecode, CCITTFaxDecode, /Crypt,
and any filter written after this — expands by an amount pdfminer will only
reveal by producing the whole output. On this machine that class is 4 of
5 142 objects, all CCITTFaxDecode, and all four are 1-bit stencil masks
(/ImageMask true, /BitsPerComponent 1) that the encoder already refused one
step later, twice over — so no picture anyone holds changes hands. An image behind one is refused
unread, with its own code asset_pdf_unbounded, and the refusal is
decided before the first link is decoded, so a document cannot make this
package pay for the links in front of the one it cannot bound. Refusing an
unknown name rather than passing it through is the same decision
corpus.resolve_gate takes for an unknown gate name: a fallback reproduces
the defect with an extra step.
An encrypted stream is deciphered and then measured. Deciphering does not
change a stream's length, so this is exactly what pdfminer's own decode()
does; before, stream.decipher is not None returned unmeasured, which made
"the document declares encryption" a way past the bound. That one is a
guarantee about the code and not a measured gain: 0 of the 5 142 image
objects on this machine sit in an encrypted document, so nobody here has ever
walked that path — which is exactly why nothing caught it.
Bounded, same fixtures, same machine:
| chain | file | peak RSS before | peak RSS after |
|---|---|---|---|
[/FlateDecode], 400 MB |
408 516 B | 59 232 256 B | 62 017 536 B |
[/FlateDecode /FlateDecode], 400 MB |
1 636 B | 886 554 624 B | 52 367 360 B |
[/FlateDecode x3], 400 MB |
1 070 B | 889 393 152 B | 61 390 848 B |
[/FlateDecode /FlateDecode], 1,2 GB |
2 927 B | 2 567 204 864 B | 60 403 712 B |
Both columns were measured on an otherwise idle machine, in paired subprocesses, from the two pinned trees. The single-link row is the control: it was already bounded and does not move. The cost no longer scales with the bomb — tripling the stream leaves the bounded run where it was, because what grows is the compressed input, which was already in memory.
An earlier pass of the same measurement, taken while two corpus censuses were
saturating this machine's memory, read 889 573 376 / 888 401 920 /
2 579 718 144 before and 94 748 672 / 91 258 880 / 107 921 408 after. The
unbounded column is the same number either way; the bounded one is not, which
is what a peak-RSS figure taken under load is worth. The figures published
above are the idle ones, and the test's own bar (PEAK_RSS_BOUND, 256 MiB)
sits above both.
MAJOR — the backstop was uncovered
check_payload(len(data), name=name) after get_data() is the counted
refusal that four documentation surfaces point at. Deleting exactly that line
passed all 2 132 tests on 0f308c1.
It is reachable: pdfminer's decode() sets rawdata to None, so a stream
something else has already decoded leaves nothing to measure, and the memory
is spent before this package is asked anything. That is now the only case
outside the bound, and it has a test. Under the deletion the refusal becomes
asset_pdf_unsupported — a code about a sample buffer, for a document that is
simply too large — which is what the test asserts against.
The cost on real documents
Every PDF on this machine — 78 documents, the K2 reference corpus in both
trinn1 and trinn2, the shipped fixtures and a 701-page reference standard — was
run through _pdf_images page by page on both sides, and each side's census
was run from a pinned tree (git archive 3b587ea for before, a copy for
after) with the imported module's own __file__ printed as the control. The
editable install was not on either path.
| before | after | |
|---|---|---|
| documents | 78 | 78 |
| images carried | 9 356 | 9 356 |
asset_pdf_unsupported |
322 | 314 |
asset_pdf_unbounded |
0 | 8 |
asset_samples_invalid |
40 | 40 |
| documents losing an image they carried | — | 0 |
| documents gaining one | — | 0 |
Not one document loses a picture, and the comparison is by NAME rather than by
count, so a swap would show. The eight that move code are the four
CCITTFaxDecode stencil masks, counted twice because trinn1 and trinn2
hold the same document: they were refused before and are refused now, one step
earlier and under a code that says why. No other rejection moves.
Mutants
Eight mutations, one line each, in the class the order named. The harness runs the unmutated tree first and asserts it passes, because a harness whose command is broken reports every mutant dead and has measured nothing.
| mutation | verdict |
|---|---|
only the first link is measured (the 0.10.1 rule restored) |
DEAD |
the link loop is dropped: only filters[0] is looked at |
DEAD |
| the running total is compared the other way round | DEAD |
| an encrypted stream is skipped again instead of deciphered | DEAD |
the backstop after get_data() is deleted |
DEAD |
| a filter the bound cannot measure is passed through | DEAD |
| the intermediate link is measured but not carried forward | DEAD |
| the whole cost check is removed from the image path | DEAD |
What this round did not do
- No tag, no push. The version stays
0.10.1and untagged; re-measuring is the PM's. - The accounting gate gained one line —
asset_pdf_unboundedinREJECTION_CODES— which is what a new rejection code requires and nothing more. - The 43-document reference corpus was not rebuilt. The image census above
is per document and per image object, which is what this change can move;
whether any concept text moves is
render_missing's open question from the previous round and is unchanged here.