voyage/tests/lib
Kjell Tore Guttormsen 29b4ac91b3
fix: round 7 of the release review of 6.3.0, for 6.3.1
Round 7 (516dffa..45aa9e1, WARN: 12 MAJOR, 0 BLOCKER) and the fence defect
found while writing its review.md. Each fix began with a test that failed on
0f400d3 (v6.3.0); suite 2208 (2206/0/2), 14 tests more.

- Tests-only (operator 2026-10-11): the plan's Files: alone decides, and the
  text says so (red-proof, trekexecute Sub-step B, step-implementer,
  HANDOVER-CONTRACTS). red-proof no longer reads the step's diff, so a change
  already in the tree when the step began no longer counts against it, and a
  plan placed outside .claude/ reads the same. The round-6 test that had the
  diff overrule the plan is rewritten to the new rule.
- The Files: reader keeps a plain file beside a backticked path
  (", Dockerfile", "the CLI entry src/cli.mjs", "and Makefile"). Measured on
  the 520 Files: fields in 182 plans: no field reads differently.
- Red proof reports a command its timeout killed as killed after the timeout,
  not "could not start"; the release check tells a timeout from output past
  its buffer and from another signal. One reading of a stop
  (criteria-runner stoppedBy) for red proof, the criteria runner and the
  release check.
- A trailing `# comment` is dropped in a backticked check too, and in a
  command passed as written, so the words screened are the words run.
- The release check reads a relative --review in --repo.
- The 15-minute timeout is defined once (criteria-runner.mjs).
- The findings check reads each cited file once per validation.
- One isMain helper (lib/util/is-main.mjs) for every CLI: the 31 copies of
  the realpath guard and the 20 modules still on the file:// guard, which
  exited 0 having done nothing under a symlink or a path with a space.
- The Bash guard writes its no-one-to-ask refusal once, on a direct condition.
- The findings check ends a ```json block only at a fence on its own line, so
  three backticks inside a JSON string no longer end it (also in 6.2.0).
- Brief-conformance notes: a test for test-lock green on exit 127 (it
  passed at once; it fails when 127 is read as could-not-run); the prose now
  names the git revision `@~1` as the one leading-@ exception.

Not changed: the example plan's steps 1-2 keep their tests-only warning
(operator decision 2026-10-09; the r5 test records it). Brief note 4 (a
Regression: whose runner is not installed goes to the fix rounds) is a
routing question for the operator.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-11 09:11:57 +02:00
..
agent-frontmatter.test.mjs fix(agents): no agent is pinned below the high floor 2026-10-05 17:40:53 +02:00
approval-log.test.mjs feat(brief): ceremony by size, one question round, logged and committed approvals 2026-10-06 19:44:42 +02:00
arch-rules.test.mjs feat(plan): plan 1.8, the plan gate, the design part and the plan-side checks 2026-10-06 20:10:57 +02:00
arg-parser.test.mjs feat(voyage): S11 — NW2 part B, integrate opt-in --workflow flag 2026-06-18 17:22:09 +02:00
artifact-commit.test.mjs feat(brief): ceremony by size, one question round, logged and committed approvals 2026-10-06 19:44:42 +02:00
atomic-write.test.mjs refactor(ultraplan-local): extract atomicWriteJson to lib/util 2026-05-01 20:21:15 +02:00
autonomy-gate.test.mjs feat(ultraplan-local): add autonomy-gate state machine + manifest schema extensions for skip_commit_check + memory_write 2026-05-04 06:28:47 +02:00
bash-normalize.test.mjs feat(ultraplan-local): Spor 1 wave 1 — lib/parsers + 66 tests grønn 2026-05-01 05:35:28 +02:00
cache-analyzer.test.mjs test(observability): close 2 MAJOR test gaps from SKAL-2 review 2026-06-26 17:14:03 +02:00
claimed-order.test.mjs test(stats): a project_dir inside cwd finds the repo that holds it 2026-10-05 12:41:44 +02:00
cleanup.test.mjs feat(voyage)!: rename produced_by field values + validator comments [skip-docs] 2026-05-05 14:42:21 +02:00
coordinator-contract.test.mjs fix(review): close the gate's fail-open paths an independent review found 2026-10-06 20:03:16 +02:00
coupling-prose-pins.test.mjs feat(trekexecute): couple the executor to the review gate, the plan approval and the step checks 2026-10-09 19:22:00 +02:00
criteria-runner.test.mjs fix: round 6 of the release review of 6.3.0 2026-10-11 01:07:47 +02:00
doc-consistency.test.mjs fix: round 7 of the release review of 6.3.0, for 6.3.1 2026-10-11 09:11:57 +02:00
done-line.test.mjs fix(execute): the step loop survives an adversarial review 2026-10-06 20:17:39 +02:00
engine-findings.test.mjs fix(review): close the gate's fail-open paths an independent review found 2026-10-06 20:03:16 +02:00
executor-prose-pins.test.mjs fix(execute): the step loop survives an adversarial review 2026-10-06 20:17:39 +02:00
fidelity-diff.test.mjs feat(review): the review is a gate - verdict in the file, CC engine, project memory 2026-10-06 19:45:52 +02:00
finding-id.test.mjs feat(ultraplan-local): add lib/parsers/finding-id.mjs (stable SHA1) 2026-05-01 13:28:05 +02:00
findings-schema.test.mjs feat(voyage): S9 — NW1 reviewer-output schema contract (TDD, ungated) 2026-06-18 14:06:07 +02:00
frontmatter.test.mjs feat(voyage)!: bulk content rewrite ultra -> voyage/trek prose [skip-docs] 2026-05-05 15:08:20 +02:00
gates-flag-coverage.test.mjs feat(voyage)!: rename commands, templates, fixtures for v4.0.0 [skip-docs] 2026-05-05 14:13:44 +02:00
gold-corpus.test.mjs feat(eval): add gold.json golden corpus + loader/validator test 2026-06-26 11:51:46 +02:00
gold-eval.test.mjs feat(eval): SKAL-1·4b offline gold-scored output eval 2026-06-30 09:00:33 +02:00
gold-scorer.test.mjs feat(eval): SKAL-1·4b offline gold-scored output eval 2026-06-30 09:00:33 +02:00
guards-prose-pins.test.mjs feat(hooks): wave-1 guards -- approval ask, plan gate, test lock, post-edit check 2026-10-06 20:09:32 +02:00
independent-review-fixes.test.mjs fix: close the six defects an independent review found in the trial fixes 2026-10-08 07:17:45 +02:00
intent-prose-pins.test.mjs feat(brief): ceremony by size, one question round, logged and committed approvals 2026-10-06 19:44:42 +02:00
jaccard.test.mjs feat(ultraplan-local): add lib/parsers/jaccard.mjs 2026-05-01 13:28:44 +02:00
main-merge-gate.test.mjs feat(voyage)!: rename commands, templates, fixtures for v4.0.0 [skip-docs] 2026-05-05 14:13:44 +02:00
manifest-schema-extensions.test.mjs feat(voyage): add OPTIONAL_STRING_KEYS path to manifest-yaml — profile_used additive 2026-05-09 09:23:32 +02:00
manifest-yaml.test.mjs feat(graceful-handoff): 2.0 — migrate to skills/ with disable-model-invocation [skip-docs] 2026-05-01 05:45:26 +02:00
no-claude-code-launch.test.mjs fix(guard): refuse every asked-about call where no one can be asked 2026-10-09 19:36:21 +02:00
phase-signal-resolver.test.mjs test(validators): cover fable accept + unknown-model reject in both gate layers 2026-07-02 16:56:26 +02:00
plan-prose-pins.test.mjs feat(plan): plan 1.8, the plan gate, the design part and the plan-side checks 2026-10-06 20:10:57 +02:00
plan-review-dedup.test.mjs feat(plan): plan 1.8, the plan gate, the design part and the plan-side checks 2026-10-06 20:10:57 +02:00
plan-schema.test.mjs feat(plan): plan 1.8, the plan gate, the design part and the plan-side checks 2026-10-06 20:10:57 +02:00
plan-scope-sweep.test.mjs feat(plan): plan 1.8, the plan gate, the design part and the plan-side checks 2026-10-06 20:10:57 +02:00
plugin-root-resolution.test.mjs feat(trekexecute): couple the executor to the review gate, the plan approval and the step checks 2026-10-09 19:22:00 +02:00
proevesett.test.mjs test(proevesett): a capitalised opposite verdict refuses says-pass/says-fail (red) 2026-09-23 11:33:19 +02:00
profile-application.test.mjs test(profiles): pin fable profile resolution end-to-end 2026-07-02 17:00:43 +02:00
profile-flag-coverage.test.mjs feat(voyage): document --profile flag in all 6 commands — SC #4 + arv-policy 2026-05-09 09:38:36 +02:00
profile-resolver.test.mjs test(profiles): pin fable profile resolution end-to-end 2026-07-02 17:00:43 +02:00
profile-stats-fields.test.mjs feat(trekresearch): emit and export the five STORM measurement fields 2026-08-09 15:01:15 +02:00
project-discovery.test.mjs feat(voyage)!: bulk content rewrite ultra -> voyage/trek prose [skip-docs] 2026-05-05 15:08:20 +02:00
reading-defects.test.mjs fix: brief template teaches runnable criteria; commands call validators through the plugin root 2026-10-08 08:52:52 +02:00
red-proof.test.mjs fix(execute): the step loop survives an adversarial review 2026-10-06 20:17:39 +02:00
release-prose-pins.test.mjs feat(release): a drilled release and rollback runbook, and a release check 2026-10-08 21:32:36 +02:00
repo-tools.test.mjs feat(hooks): wave-1 guards -- approval ask, plan gate, test lock, post-edit check 2026-10-06 20:09:32 +02:00
research-loop-cap.test.mjs feat(research-loop-cap): give the discovery ceiling a reader, not just a sentence 2026-08-12 23:09:11 +02:00
retired-references.test.mjs test(hygiene): no tracked file may carry a retired-repository reference (red) 2026-09-23 12:25:43 +02:00
retterunde-prose-pins.test.mjs fix: the fix round before 6.3.0 (order 10) 2026-10-09 22:16:12 +02:00
retterunde.test.mjs fix(examples): the verbose-content test moves into the step that wires it [skip-docs] 2026-10-09 22:24:03 +02:00
review-630.test.mjs fix: round 7 of the release review of 6.3.0, for 6.3.1 2026-10-11 09:11:57 +02:00
review-determinism.test.mjs feat(voyage)!: rename commands, templates, fixtures for v4.0.0 [skip-docs] 2026-05-05 14:13:44 +02:00
review-findings-kept.test.mjs fix: the second lekerepo trial's faults that made a result wrong or misleading 2026-10-08 15:12:07 +02:00
review-prose-pins.test.mjs fix(review): a review with a control that did not run stops a merge 2026-10-06 20:06:29 +02:00
review-recurrence.test.mjs fix(review): close the gate's fail-open paths an independent review found 2026-10-06 20:03:16 +02:00
rule-catalogue.test.mjs fix: the second lekerepo trial's faults that made a result wrong or misleading 2026-10-08 15:12:07 +02:00
session-orders.test.mjs test(execute): Check 4 and Step 5 must survive a first run under zsh (red) 2026-10-02 16:40:05 +02:00
skill-lint.test.mjs feat(skills): skill workshop, test-first and debugging preloaded into the step helper 2026-10-08 21:38:58 +02:00
skill-routing.test.mjs feat(skills): skill workshop, test-first and debugging preloaded into the step helper 2026-10-08 21:38:58 +02:00
skills-research-prose-pins.test.mjs merge: main (7a skills workshop, 9 rettepakke) into wave2-skills-research 2026-10-09 19:34:38 +02:00
skills-workshop-prose-pins.test.mjs feat(skills): skill workshop, test-first and debugging preloaded into the step helper 2026-10-08 21:38:58 +02:00
source-findings.test.mjs feat(voyage)!: bulk content rewrite ultra -> voyage/trek prose [skip-docs] 2026-05-05 15:08:20 +02:00
stats-event-emit.test.mjs fix(execute): the Phase 8 payload goes on stdin; /trekreview findings closed 2026-10-05 18:16:46 +02:00
stats-landing.test.mjs fix(execute): the Phase 8 payload goes on stdin; /trekreview findings closed 2026-10-05 18:16:46 +02:00
step-check.test.mjs feat(hooks): wave-1 guards -- approval ask, plan gate, test lock, post-edit check 2026-10-06 20:09:32 +02:00
synthesis-digest-schema.test.mjs feat(voyage): S12 — NW3 synthesis-agent built + measured → declined per measurement [skip-docs] 2026-06-18 17:58:39 +02:00
test-census.test.mjs feat(eval): SKAL-1·4b offline gold-scored output eval 2026-06-30 09:00:33 +02:00
test-integrity.test.mjs fix(execute): the step loop survives an adversarial review 2026-10-06 20:17:39 +02:00
test-lock.test.mjs feat(hooks): wave-1 guards -- approval ask, plan gate, test lock, post-edit check 2026-10-06 20:09:32 +02:00
timing-under-load.test.mjs fix: the fix round before 6.3.0 (order 10) 2026-10-09 22:16:12 +02:00
token-usage.test.mjs feat(stats): add claude-fable-5 to PRICE_TABLE 2026-07-02 17:15:36 +02:00
trial-mechanical-fixes.test.mjs fix: the trial's mechanical faults -- approval label, import path, stats, annotate path, red kind 2026-10-08 06:53:15 +02:00
trial2-fixes.test.mjs fix: close what an independent review found in the trial 2 fixes 2026-10-08 15:21:56 +02:00
trial2-minor-prose-pins.test.mjs feat(trekplan): Regression and On failure step rules, and trial 2's minor fixes 2026-10-08 21:42:21 +02:00
trial2-minor.test.mjs feat(trekplan): Regression and On failure step rules, and trial 2's minor fixes 2026-10-08 21:42:21 +02:00
verdict-gate.test.mjs fix(review): a review with a control that did not run stops a merge 2026-10-06 20:06:29 +02:00