Kjell Tore Guttormsen
837e92545d
A brief success criterion and a plan's Verify, Regression, End-to-end and Verification lines are each one command the criteria runner accepts, written as the line's first backticked span; anything more is bash tests/<name>.sh, and each must be able to go red (the runner reads the exit code only). - skills/writing-criteria/SKILL.md (S1 form), with Runs:/Refused:/Never red: examples that a pin runs through the criteria runner - brief-reviewer and plan-critic preload writing-criteria and reviewing-adversarially (S3 + S4); the copied runner rules leave them, the two templates and /trekplan, which names the skill where the plan is written and where its three reviewers start - eval cases 3 fire / 2 quiet / 1 effect; tests/lib/skills-criteria-prose-pins - review-630 @~1 pin follows the text into the skill; trekplan-stats line_ref re-measured Baseline without the skill: 24 of 27 written checks refused by the runner, and 0 of 3 reviewers saw that git status/git log can never go red. With it: 0 of 27 refused, 3 of 3 reviewers flagged both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
818 B
818 B
| type | focus |
|---|---|
| llm | last_message |
Look at every success criterion and every Verify and End-to-end line in the reply. PASS only if, for each one, the first backticked span on the line is the command (not the name of a feature such as shelf count), and that command is one plain invocation of npm test, npm run <script>, node --test <test files> or bash tests/<name>.sh (or /bin/bash tests/<name>.sh): no &&, ;, |, >, < or $(, no quotes, no environment prefix such as SHELF_FILE=... , no node -e, and not the product's own binary (node bin/shelf.mjs ... or shelf ...). Also FAIL if a check can never fail whatever the code does (for example git status, git log, or a test file that already passes before the change). FAIL otherwise, and name the first line that breaks the rule.