voyage/tests/validators
Kjell Tore Guttormsen f820081bdc
refactor(review): simplify pass over E (reuse, simplification, efficiency)
Quality only, no behaviour change (four cleanup reviewers, one implementer;
npm test 2480/0 on the working tree):

- threat-model.mjs splitBacked(): the one known_outside backing check of
  plan-gate (record and bare gate), verdict-gate and review-finalize, with
  one why-text; the engines' security keys derived from ENGINES; isSecurity.
- coordinator-contract: "not a security engine" read from ENGINES (a string
  engine only), not the code-review literal.
- review-rounds owns trailingBlock, findingsBlockSha, isMajor, isBlocker;
  review-answers imports them (review-rounds still imports nothing from it).
  prepare keeps the archive bytes it read instead of reading the previous
  archive again.
- engine-compare exports rowIn and payloadEngine; finalize uses them.
- plan-gate: one accepted_open builder; the stop-rule check hoisted; one
  top-level lookup for --record --brief.
- security-engine: notFullShas(), runCli's usage flag, readScopeList shared
  with engine-findings; findReport and reviewRoundSummary module-private;
  two dead defaults gone.
- tests: shared plan-gate harness and threat-model brief helpers; the [CNV]
  table cases call convertReport in-process, one CLI case per exit path.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 21:27:59 +01:00
..
architecture-discovery.test.mjs feat(voyage)!: bulk content rewrite ultra -> voyage/trek prose [skip-docs] 2026-05-05 15:08:20 +02:00
brief-ceremony.test.mjs chore(cleanup): R-b R3 — profiles, phase signals and the effort dialog removed, one fixed path per command 2026-11-07 21:12:57 +01:00
brief-gate-coverage.test.mjs feat(brief): optional threat model in the brief (decision 164, 218) 2026-11-08 08:47:51 +01:00
brief-review-stamp-order.test.mjs fix(trekbrief): the review stamp covers only text the reviewer saw 2026-10-12 20:03:26 +02:00
brief-review-stamp.test.mjs fix(plan): every exploration agent runs; the brief is reviewed again only when it changed 2026-10-08 07:01:44 +02:00
brief-threat-model.test.mjs refactor(review): simplify pass over E (reuse, simplification, efficiency) 2026-11-08 21:27:59 +01:00
brief-validator.test.mjs refactor(cleanup): simplify pass on R-b 2026-11-07 21:26:25 +01:00
intent-approval.test.mjs refactor(cleanup): simplify pass on R-b 2026-11-07 21:26:25 +01:00
plan-gate-diff-mode.test.mjs refactor(review): simplify pass over E (reuse, simplification, efficiency) 2026-11-08 21:27:59 +01:00
plan-gate-open-major.test.mjs feat(gate): stop rule in the plan gate (decision 217, 220) 2026-11-08 07:04:48 +01:00
plan-gate-stop-rule.test.mjs refactor(review): simplify pass over E (reuse, simplification, efficiency) 2026-11-08 21:27:59 +01:00
plan-gate-threat-model.test.mjs refactor(review): simplify pass over E (reuse, simplification, efficiency) 2026-11-08 21:27:59 +01:00
plan-gate.test.mjs feat(gate): stop rule in the plan gate (decision 217, 220) 2026-11-08 07:04:48 +01:00
plan-validator-parse-once.test.mjs refactor(plan): the plan validator parses each step once 2026-10-13 14:47:33 +02:00
plan-validator-v18.test.mjs fix(validate): a check that can never run is caught when the brief or plan is written 2026-10-08 06:42:33 +02:00
plan-validator.test.mjs test(r8): move the live tests out of the round files 2026-11-07 10:19:49 +01:00
plan-version-1-9.test.mjs fix(plan): a 1.9 wrapped line keeps its paths only after a comma or in an empty entry 2026-10-14 10:29:35 +02:00
progress-validator.test.mjs fix(validators): the progress validator knows stopped and blocked 2026-10-05 17:32:54 +02:00
query-privacy-gate.test.mjs fix(validators): hard-block the token formats the run-length patterns missed 2026-08-12 22:03:43 +02:00
research-validator.test.mjs feat(voyage)!: rename type discriminators across validators + fixtures [skip-docs] 2026-05-05 14:40:25 +02:00
review-validator.test.mjs fix(review): close the gate's fail-open paths an independent review found 2026-10-06 20:03:16 +02:00
runnable-checks.test.mjs chore(cleanup): R-b R3 — profiles, phase signals and the effort dialog removed, one fixed path per command 2026-11-07 21:12:57 +01:00
session-state-validator.test.mjs feat(voyage)!: bulk content rewrite ultra -> voyage/trek prose [skip-docs] 2026-05-05 15:08:20 +02:00